Pin definitions when building an older version #4155
Merged
+39
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kfranqueiro marked as non substantive for IPR from ash-nazg. |
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
iadawn
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #4007, in which I had neglected to pin definitions for key terms to the published recommendation when building for 2.1.
termsMapdefinition to the Eleventy config (where all other target-version-dependent assignments are made), to be passed into theCustomLiquidconstructortermsMapreferences withinCustomLiquidto use an instance variable set in the constructorloadRemoteGuidelinesto account for pre-processed terms contentrenderprocessing for pages not being output for 2.1 (to avoid irrelevant error messages as well as save time)